fix: don't run teardown effects when deriveds are unfreezed#18227
Merged
Conversation
The logic was flawed - a teardown effect only has a teardown function but not `fn` property, but unfreeze thought that everything with a `teardown` needs to be unfreezed
🦋 Changeset detectedLatest commit: 7611b4b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Member
|
teardown(() => {...});
render_effect(() => () => {...});
Edit: I understand now! |
Rich-Harris
approved these changes
May 18, 2026
Merged
dummdidumm
pushed a commit
that referenced
this pull request
May 18, 2026
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## svelte@5.55.8 ### Patch Changes - fix(print): handle `svelte:body` and fix keyframe percentage double-printing ([#18234](#18234)) - fix: execute uninitialized derived even if it's destroyed ([#18228](#18228)) - fix: use named symbols everywhere ([#18238](#18238)) - fix: don't run teardown effects when deriveds are unfreezed ([#18227](#18227)) - fix: unset context synchronously in `run` ([#18236](#18236)) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The logic was flawed - a teardown effect only has a teardown function but not
fnproperty, but unfreeze thought that everything with ateardownneeds to be unfreezedHelps with #18221 (though likely doesn't fix it completely, at least not the more general
batch.#rootsproblems)