fix: cleanup superTypeParameters in ClassDeclarations/ClassExpression#18015
Merged
dummdidumm merged 3 commits intomainfrom Mar 28, 2026
Merged
fix: cleanup superTypeParameters in ClassDeclarations/ClassExpression#18015dummdidumm merged 3 commits intomainfrom
superTypeParameters in ClassDeclarations/ClassExpression#18015dummdidumm merged 3 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: f751503 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Member
Author
|
FFS |
681d656 to
5eef89d
Compare
Member
|
I think we should add this to the existing runtime-runes/samples/typescript test instead of creating a snapshot test, otherwise 👍 |
Member
Author
Oh yeah good idea...moved it there |
dummdidumm
approved these changes
Mar 28, 2026
Merged
Rich-Harris
pushed a commit
that referenced
this pull request
Mar 29, 2026
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## svelte@5.55.1 ### Patch Changes - fix: correctly handle bindings on the server ([#18009](#18009)) - fix: prevent hydration error on async `{@html ...}` ([#17999](#17999)) - fix: cleanup `superTypeParameters` in `ClassDeclarations`/`ClassExpression` ([#18015](#18015)) - fix: improve duplicate module import error message ([#18016](#18016)) - fix: reschedule new effects in prior batches ([#18021](#18021)) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #18012
This is incredibly weird: in our playground AND in our test suite the generic was correctly stripped. But if you installed
svelteand compiled the same code the generic was there (and it was like this since version5.35.0when we bumpedesrap).We were removing
superTypeArgumentsbut the AST showedsuperTypeParameters.My gut feeling is that recently there's been some upstream change that either changed the parsing or the printing and it was not showing up in our test suite because the lockfile was outdated. I hade to remove that plus thenode_modulesand re-install to make the test actually fail (before being able to fix it).Ok, updating the whole lockfile made lint and test fail miserably. Luckily, I was able to pinpoint
esrap@2.2.4as the cause... I've only bumpedesrapand that made the test fail (so that I could fix it)And of course it was that...there's literally a commit that explicitly print them lol
sveltejs/esrap@f9137c4