fix: SvelteURL search setter uses unnormalized value#17828
Merged
Rich-Harris merged 1 commit intosveltejs:mainfrom Feb 27, 2026
Merged
fix: SvelteURL search setter uses unnormalized value#17828Rich-Harris merged 1 commit intosveltejs:mainfrom
Rich-Harris merged 1 commit intosveltejs:mainfrom
Conversation
The search setter stored the raw input `value` instead of `super.search`, unlike every other setter in SvelteURL. This caused `url.search` to return incorrect values when the URL API normalizes the input (e.g. adding the `?` prefix or stripping a lone `?`). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: a9d558f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Merged
Rich-Harris
pushed a commit
that referenced
this pull request
Feb 27, 2026
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## svelte@5.53.6 ### Patch Changes - perf: optimize parser hot paths for faster compilation ([#17811](#17811)) - fix: `SvelteMap` incorrectly handles keys with `undefined` values ([#17826](#17826)) - fix: SvelteURL `search` setter now returns the normalized value, matching native URL behavior ([#17828](#17828)) - fix: visit synthetic value node during ssr ([#17824](#17824)) - fix: always case insensitive event handlers during ssr ([#17822](#17822)) - chore: more efficient effect scheduling ([#17808](#17808)) - perf: optimize compiler analysis phase ([#17823](#17823)) - fix: skip redundant batch.apply ([#17816](#17816)) - chore: null out current_batch before committing branches ([#17809](#17809)) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SvelteURLsearchsetter stored the raw inputvalueinstead ofsuper.search, unlike every other setter in the classurl.searchto return incorrect values when the URL API normalizes the input (e.g. adding the?prefix, or stripping a lone?)url.search = 'foo=bar'would return'foo=bar'instead of'?foo=bar'Test plan
url.search normalizes valuetest covering:?prefix?prefix (existing behavior)?(normalized to"")🤖 Generated with Claude Code