fix: avoid 'node:crypto' cloudflare warnings#17612
Merged
Rich-Harris merged 4 commits intomainfrom Feb 4, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: b30fadb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
teemingc
commented
Feb 4, 2026
paoloricciuti
approved these changes
Feb 4, 2026
Member
paoloricciuti
left a comment
There was a problem hiding this comment.
I think it's fine but also if it's a false positive maybe it should be solved in wrangler/esbuild?
Member
|
It's not really a false positive — this code should error in non-Node environments, it's just that it will never run in any of the non-Node environments we care about. So this LGTM I think |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See sveltejs/kit#15056 (comment)
Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.packages/svelte/src, add a changeset (npx changeset).Tests and linting
pnpm testand lint the project withpnpm lint