fix: avoid unnecessary block effect re-runs after async work completes#17535
Merged
Rich-Harris merged 4 commits intosveltejs:mainfrom Jan 25, 2026
Merged
fix: avoid unnecessary block effect re-runs after async work completes#17535Rich-Harris merged 4 commits intosveltejs:mainfrom
Rich-Harris merged 4 commits intosveltejs:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 42682fc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
6 tasks
Contributor
|
Rich-Harris
approved these changes
Jan 25, 2026
Member
Rich-Harris
left a comment
There was a problem hiding this comment.
that's a neat fix! would still love to avoid rescheduling in the first place, since they've already run, but we can leave figuring out how to make that work for another time
Merged
This was referenced Jan 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #17471, fixes #17394
A much simpler alternative to #17500. This marks block effects as maybe dirty on
Batch.revive(), forcing a dep check, and thus skipping re-runs of blocks that haven't changed (eg. each await nested inside an each over a store).Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.packages/svelte/src, add a changeset (npx changeset).Tests and linting
pnpm testand lint the project withpnpm lint