fix: correctly parse escaped unicode characters in css selector#15976
Merged
Rich-Harris merged 1 commit intosveltejs:mainfrom May 24, 2025
Merged
fix: correctly parse escaped unicode characters in css selector#15976Rich-Harris merged 1 commit intosveltejs:mainfrom
Rich-Harris merged 1 commit intosveltejs:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 5877d1a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Contributor
Author
I couldn't get this behavior triggered in vanilla HTML, so I'm puzzled where it applies. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found in https://discord.com/channels/457912077277855764/1372972353213960232
Specs: https://www.w3.org/TR/CSS22/syndata.html#characters
The unicode sequences (
\123) weren't considered that caused falsy css_unused_selector and even css_expected_identifier (#\31 23is a valid selector ofid="123").Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.packages/svelte/src, add a changeset (npx changeset).Tests and linting
pnpm testand lint the project withpnpm lint