Skip to content

feat: allow generics on snippets#15915

Merged
Rich-Harris merged 6 commits intomainfrom
generic-snippets
May 14, 2025
Merged

feat: allow generics on snippets#15915
Rich-Harris merged 6 commits intomainfrom
generic-snippets

Conversation

@paoloricciuti
Copy link
Copy Markdown
Member

@paoloricciuti paoloricciuti commented May 14, 2025

Closes #15883

This adds support for the parser for the generic syntax on snippets...this can be useful for stuff like

{#snippet list<TItem>(list: TItem[], show: (item: TItem)=>boolean)}
    {#each list as item}
        {#if show(item)}
             {item}
        {/if}
    {/each}
{/snippet}

to be actually functional needs a respective pr in language-tools

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 14, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 48d78ab

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@svelte-docs-bot
Copy link
Copy Markdown

svelte-docs-bot Bot commented May 14, 2025

Preview: https://svelte-dev-git-preview-svelte-15915-svelte.vercel.app/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 14, 2025

Playground

pnpm add https://pkg.pr.new/svelte@15915

@Rich-Harris
Copy link
Copy Markdown
Member

Rich-Harris commented May 14, 2025

I think we can reuse some existing bracket matching logic (which is already slightly duplicative) — will push a change

@paoloricciuti
Copy link
Copy Markdown
Member Author

paoloricciuti commented May 14, 2025

Uh great idea, thanks

Rich-Harris
Rich-Harris reviewed May 14, 2025
View reviewed changes
Comment thread packages/svelte/src/compiler/phases/1-parse/state/tag.js Outdated
@Rich-Harris Rich-Harris merged commit 66a2155 into main May 14, 2025
13 checks passed
@Rich-Harris Rich-Harris deleted the generic-snippets branch May 14, 2025 19:59
@github-actions github-actions Bot mentioned this pull request May 14, 2025
Merged
@WarningImHack3r
Copy link
Copy Markdown

WarningImHack3r commented May 14, 2025

Oh, that was fast and unexpected, thanks Paolo & Rich!!

@paoloricciuti paoloricciuti mentioned this pull request May 14, 2025
Merged
@traviszuleger
Copy link
Copy Markdown

traviszuleger commented Feb 11, 2026 •
edited
Loading

Is it possible for this to be accomplished in JSDOC?

See this snippet for example:

<!-- How do I declare generic T with JSDOC? -->
{#snippet example(
  /** @type {T[]} */ items,
  /** @type {(item: T) => string} */ getItemLabel,
  /** @type {(item: T) => string} */ getItemKey
)}
  {#each items as item}
    {@const key = getItemKey(item)}
    {#key key}
      {getItemLabel(item)}
    {/key}
  {/each}
{/snippet}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Rich-Harris Rich-Harris Rich-Harris approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support TypeScript generics on snippets

4 participants

@paoloricciuti @Rich-Harris @WarningImHack3r @traviszuleger