Skip to content

fix: update state_referenced_locally message#15733

Merged
Rich-Harris merged 3 commits intomainfrom
state-referenced-locally-message
Apr 11, 2025
Merged

fix: update state_referenced_locally message#15733
Rich-Harris merged 3 commits intomainfrom
state-referenced-locally-message

Conversation

@Rich-Harris
Copy link
Copy Markdown
Member

alternative to #15171. closes #11883, closes #13079.

In addition to tweaking the message (and suggesting a derived instead of a closure when the reference is inside a $state declaration, per #15171 (comment)) it tweaks the detailed description the message links to.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 11, 2025

🦋 Changeset detected

Latest commit: 8eb15c3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@svelte-docs-bot
Copy link
Copy Markdown

@github-actions
Copy link
Copy Markdown
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@15733

@Rich-Harris Rich-Harris merged commit 95a020a into main Apr 11, 2025
13 checks passed
@Rich-Harris Rich-Harris deleted the state-referenced-locally-message branch April 11, 2025 14:01
@Rich-Harris
Copy link
Copy Markdown
Member Author

merged per discussion in #15171

@github-actions github-actions Bot mentioned this pull request Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

state_reference_locally warning message is unclear Svelte 5: Confusing and unclear warning state_referenced_locally

1 participant