fix: don't throw for undefined non delegated event handlers#15087
Merged
paoloricciuti merged 2 commits intomainfrom Jan 22, 2025
Merged
fix: don't throw for undefined non delegated event handlers#15087paoloricciuti merged 2 commits intomainfrom
undefined non delegated event handlers#15087paoloricciuti merged 2 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: ea99f27 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
dummdidumm
approved these changes
Jan 22, 2025
Member
dummdidumm
left a comment
There was a problem hiding this comment.
looks good apart from a typing suggestion
| if (!event.cancelBubble) { | ||
| return without_reactive_context(() => { | ||
| return handler.call(this, event); | ||
| return handler?.call(this, event); |
Member
There was a problem hiding this comment.
we should probably also adjust the call signature to allow undefined for the handler param, and adjust that for export function event(...) aswell
Member
Author
There was a problem hiding this comment.
Oh good catch...gonna fix them soon
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #15081
Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.packages/svelte/src, add a changeset (npx changeset).Tests and linting
pnpm testand lint the project withpnpm lint