Skip to content

fix: correctly handle novalidate attribute casing#15083

Merged
dummdidumm merged 4 commits intosveltejs:mainfrom
Rican7:bugfix/novalidate-attribute-rendering
Jan 22, 2025
Merged

fix: correctly handle novalidate attribute casing#15083
dummdidumm merged 4 commits intosveltejs:mainfrom
Rican7:bugfix/novalidate-attribute-rendering

Conversation

@Rican7
Copy link
Copy Markdown
Contributor

@Rican7 Rican7 commented Jan 22, 2025

This PR fixes #15082 by correctly handling the HTML element novalidate attribute casing through noValidate DOM property mapping.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jan 22, 2025

🦋 Changeset detected

Latest commit: 304b613

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Copy Markdown
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@github-actions
Copy link
Copy Markdown
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@15083

Comment thread packages/svelte/tests/runtime-runes/samples/form-novalidate-casing/_config.js Outdated
@dummdidumm dummdidumm merged commit eee808f into sveltejs:main Jan 22, 2025
@github-actions github-actions Bot mentioned this pull request Jan 22, 2025
@Rican7
Copy link
Copy Markdown
Contributor Author

Rican7 commented Jan 22, 2025

Thank you so much for the quick review and merge!

@Rican7 Rican7 deleted the bugfix/novalidate-attribute-rendering branch January 22, 2025 22:51
@github-actions github-actions Bot mentioned this pull request Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Form novalidate attribute doesn't render when conditional (given a value)

2 participants