Skip to content

fix: consistently set value to blank string when value attribute is undefined#15057

Merged
dummdidumm merged 2 commits intosveltejs:mainfrom
theodorejb:undefined-value
Jan 22, 2025
Merged

fix: consistently set value to blank string when value attribute is undefined#15057
dummdidumm merged 2 commits intosveltejs:mainfrom
theodorejb:undefined-value

Conversation

@theodorejb
Copy link
Copy Markdown
Contributor

@theodorejb theodorejb commented Jan 19, 2025 •
edited
Loading

Previously there was an inconsistency where a value attribute (correctly) wasn't set if initially undefined (resulting in the input value being a blank string), but if the value attribute was first set to a non-nullish value, and then changed to undefined, then the string "undefined" would appear as the input value, rather than the expected empty string.

Fixes #4467

@Rich-Harris
Copy link
Copy Markdown
Member

Rich-Harris commented Jan 19, 2025

preview: https://svelte-dev-git-preview-svelte-15057-svelte.vercel.app/

this is an automated message

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 19, 2025

Playground

pnpm add https://pkg.pr.new/svelte@15057

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jan 19, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 3d10f41

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@theodorejb
Copy link
Copy Markdown
Contributor Author

theodorejb commented Jan 22, 2025

@dummdidumm Can you review this?

We ran into bugs from this where an input value was set from an optional URL param. E.g:

<input name="address" value={params.address} />

This appears to work great at first, since when the parameter isn't set initially the input is blank, and when the parameter is added it is displayed as expected in the input. But if a subsequent navigation removes the parameter after it had been set, the input unexpectedly shows "undefined".

@dummdidumm
Copy link
Copy Markdown
Member

dummdidumm commented Jan 22, 2025

Looks good, thanks! Add a changeset and we're good to merge 👍

@dummdidumm dummdidumm merged commit c2e805f into sveltejs:main Jan 22, 2025
@github-actions github-actions Bot mentioned this pull request Jan 22, 2025
Merged
@theodorejb theodorejb deleted the undefined-value branch January 22, 2025 20:24
@github-actions github-actions Bot mentioned this pull request Jan 25, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dummdidumm dummdidumm dummdidumm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

undefined value on input and other elements

3 participants

@theodorejb @Rich-Harris @dummdidumm