Skip to content

fix: omit unnecessary nullish coallescing in template expressions#15056

Merged
paoloricciuti merged 2 commits intosveltejs:mainfrom
Ocean-OS:omit-unnecessary-coallescence
Jan 20, 2025
Merged

fix: omit unnecessary nullish coallescing in template expressions#15056
paoloricciuti merged 2 commits intosveltejs:mainfrom
Ocean-OS:omit-unnecessary-coallescence

Conversation

@Ocean-OS
Copy link
Copy Markdown
Member

@Ocean-OS Ocean-OS commented Jan 19, 2025 •
edited
Loading

Currently, Svelte will almost always append a nullish coallescence statement (maybeNullish ?? alternate) to any interpolations in a template expression, regardless of whether there already is one. This changes that, so that nullish coallescence to a non-null literal will stay the same, and in stuff ?? null cases, null is replaced with an empty string.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jan 19, 2025

🦋 Changeset detected

Latest commit: e58a65a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris
Copy link
Copy Markdown
Member

Rich-Harris commented Jan 19, 2025

preview: https://svelte-dev-git-preview-svelte-15056-svelte.vercel.app/

this is an automated message

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 19, 2025

Playground

pnpm add https://pkg.pr.new/svelte@15056

@paoloricciuti
Copy link
Copy Markdown
Member

paoloricciuti commented Jan 19, 2025

Can you also add a test for this?

@Ocean-OS
Copy link
Copy Markdown
Member Author

Ocean-OS commented Jan 19, 2025 •
edited
Loading

Can you also add a test for this?

Which section of the test folder should I put it in? None of them seem to really match this PR. (Apologies for not responding until now, in my timezone you sent that message at 2 am 😅)

@paoloricciuti
Copy link
Copy Markdown
Member

paoloricciuti commented Jan 19, 2025

Can you also add a test for this?

Which section of the test folder should I put it in? None of them seem to really match this PR. (Apologies for not responding until now, in my timezone you sent that message at 2 am 😅)

You can probably put something in snapshots

@paoloricciuti
Copy link
Copy Markdown
Member

paoloricciuti commented Jan 20, 2025

Thanks!

@paoloricciuti paoloricciuti merged commit 5f6525f into sveltejs:main Jan 20, 2025
@github-actions github-actions Bot mentioned this pull request Jan 18, 2025
Merged
@Rich-Harris Rich-Harris mentioned this pull request Jan 22, 2025
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paoloricciuti paoloricciuti paoloricciuti approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Ocean-OS @Rich-Harris @paoloricciuti