Skip to content

fix: avoid marking subtree as dynamic for inlined attributes#14269

Merged
Rich-Harris merged 42 commits intomainfrom
inlined-attribute-static-er
Nov 14, 2024
Merged

fix: avoid marking subtree as dynamic for inlined attributes#14269
Rich-Harris merged 42 commits intomainfrom
inlined-attribute-static-er

Conversation

@paoloricciuti
Copy link
Copy Markdown
Member

@paoloricciuti paoloricciuti commented Nov 11, 2024 •
edited by dummdidumm
Loading

Closes #14241 (this time for real...i don't think we can get less than this but happy to be proved wrong by @benmccann 😄 )

I've restructured the code a bit to have a shared utils.

Also fixes #14292

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Nov 11, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 61b60ab

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris
Copy link
Copy Markdown
Member

Rich-Harris commented Nov 11, 2024

preview: https://svelte-dev-git-preview-svelte-14269-svelte.vercel.app/

this is an automated message

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 11, 2024

Playground

pnpm add https://pkg.pr.new/svelte@14269

Rich-Harris
Rich-Harris reviewed Nov 11, 2024
View reviewed changes
Comment thread packages/svelte/src/compiler/phases/2-analyze/visitors/ExpressionTag.js Outdated
Rich-Harris
Rich-Harris reviewed Nov 11, 2024
View reviewed changes
Comment thread packages/svelte/src/compiler/phases/utils.js Outdated
Rich-Harris
Rich-Harris reviewed Nov 11, 2024
View reviewed changes
Comment thread packages/svelte/src/compiler/phases/utils.js Outdated
@paoloricciuti
Copy link
Copy Markdown
Member Author

paoloricciuti commented Nov 12, 2024

Also for some reason when i tried to import extract_all_identifiers_from_expression it was not able to run the playground anymore 🤷🏼

benmccann
benmccann reviewed Nov 12, 2024
View reviewed changes
Comment thread packages/svelte/src/compiler/phases/3-transform/client/visitors/shared/fragment.js Outdated
paoloricciuti and others added 2 commits November 12, 2024 21:11
@paoloricciuti @benmccann
chore: simpler check first
63d96ca 
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
@Rich-Harris
typo
d920a23
Rich-Harris
Rich-Harris reviewed Nov 13, 2024
View reviewed changes
Comment thread packages/svelte/src/compiler/phases/3-transform/client/visitors/shared/utils.js Outdated
Rich-Harris
Rich-Harris reviewed Nov 14, 2024
View reviewed changes
Comment thread packages/svelte/src/compiler/phases/utils.js Outdated
Rich-Harris
Rich-Harris reviewed Nov 14, 2024
View reviewed changes
Comment thread packages/svelte/src/compiler/phases/utils.js Outdated
Rich-Harris
Rich-Harris reviewed Nov 14, 2024
View reviewed changes
Comment thread packages/svelte/src/compiler/phases/utils.js Outdated
Rich-Harris
Rich-Harris reviewed Nov 14, 2024
View reviewed changes
Comment thread packages/svelte/src/compiler/phases/3-transform/client/visitors/shared/fragment.js Outdated
@dummdidumm dummdidumm mentioned this pull request Nov 14, 2024
Closed
@paoloricciuti
Copy link
Copy Markdown
Member Author

paoloricciuti commented Nov 14, 2024

@Rich-Harris obviously thanks for taking care of solving this...I suspected something was very wrong (I can't be at the desk now but please let me know if I need to do something) 🤟🏻

benmccann
benmccann reviewed Nov 14, 2024
View reviewed changes
Comment thread packages/svelte/src/compiler/phases/2-analyze/visitors/Identifier.js Outdated
@Rich-Harris @benmccann
Update packages/svelte/src/compiler/phases/2-analyze/visitors/Identif…
cf7c15c 
…ier.js

Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
Rich-Harris
Rich-Harris reviewed Nov 14, 2024
View reviewed changes
Comment thread .changeset/spotty-sheep-fetch.md Outdated
Rich-Harris
Rich-Harris reviewed Nov 14, 2024
View reviewed changes
Comment thread .changeset/spotty-sheep-fetch.md Outdated
@Rich-Harris Rich-Harris merged commit 8a8e6f7 into main Nov 14, 2024
@Rich-Harris Rich-Harris deleted the inlined-attribute-static-er branch November 14, 2024 17:48
@github-actions github-actions Bot mentioned this pull request Nov 14, 2024
Merged
@brunnerh brunnerh mentioned this pull request Nov 15, 2024
Closed
@trueadm trueadm mentioned this pull request Nov 16, 2024
Closed
@Rich-Harris Rich-Harris mentioned this pull request Nov 16, 2024
Merged
@Razunter Razunter mentioned this pull request Nov 19, 2024
Closed
@trueadm trueadm mentioned this pull request Nov 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benmccann benmccann benmccann left review comments

@Rich-Harris Rich-Harris Rich-Harris approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Versions >5.1.14 causing TypeError: Illegal invocation error Compiler output bloat

3 participants

@paoloricciuti @Rich-Harris @benmccann