Returning here with true could lead to bugs down the road in case a condition afterwards would return false

But the subsequent checks are only for static text attributes right?

Uh i guess except the last one which is about the node name itself...let me see what are we doing in that case

Very good catch !

Oh but actually i'm stuped because the rest only checks for the name so it can be problematic there too

I moved this check last and moved the check for node.name outside the for loop since it didn't had to be inside the loop

Oh but wait it's not all actually...because i need to loop over every attribute before returning true

Ok now it's fixed for real...i wonder if we should add some snapshots for this case to prevent easy regressions

Let's add some snapshot tests, this code is very fragile without.