Skip to content

fix: consider img with loading attribute not static#14237

Merged
paoloricciuti merged 3 commits intomainfrom
loading-lazy-no-static
Nov 10, 2024
Merged

fix: consider img with loading attribute not static#14237
paoloricciuti merged 3 commits intomainfrom
loading-lazy-no-static

Conversation

@paoloricciuti
Copy link
Copy Markdown
Member

@paoloricciuti paoloricciuti commented Nov 9, 2024

Closes #14235

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 9, 2024

Playground

pnpm add https://pkg.pr.new/svelte@14237

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Nov 10, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 2b439bc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

benmccann
benmccann reviewed Nov 10, 2024
View reviewed changes
Comment thread packages/svelte/src/compiler/phases/3-transform/client/visitors/shared/fragment.js Outdated
@paoloricciuti @benmccann
chore: better comment
2b439bc 
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
@paoloricciuti paoloricciuti merged commit d207666 into main Nov 10, 2024
@paoloricciuti paoloricciuti deleted the loading-lazy-no-static branch November 10, 2024 16:48
@github-actions github-actions Bot mentioned this pull request Nov 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benmccann benmccann benmccann approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

img with loading attribute will lead to "read properties of undefined (reading 'loading')"

2 participants

@paoloricciuti @benmccann