Skip to content

fix: correctly infer <a> tag namespace#14134

Merged
dummdidumm merged 1 commit intomainfrom
a-tag-namespace-fix
Nov 3, 2024
Merged

fix: correctly infer <a> tag namespace#14134
dummdidumm merged 1 commit intomainfrom
a-tag-namespace-fix

Conversation

@dummdidumm
Copy link
Copy Markdown
Member

@dummdidumm dummdidumm commented Nov 3, 2024

<a> tags are valid in both the SVG and HTML namespace. If there's no parent, we therefore have to look downwards to see if it's the parent of a SVG or HTML element.

fixes #7807
fixes #13793

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

@dummdidumm
fix: correctly infer <a> tag namespace
7e70188 
 `<a>` tags are valid in both the SVG and HTML namespace.  If there's no parent, we therefore have to look downwards to see if it's the parent of a SVG or HTML element.

fixes #7807
fixes #13793
@Rich-Harris
Copy link
Copy Markdown
Member

Rich-Harris commented Nov 3, 2024

preview: https://svelte-dev-git-preview-svelte-14134-svelte.vercel.app/

this is an automated message

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Nov 3, 2024 

pnpm add https://pkg.pr.new/svelte@14134

commit: 7e70188

@trueadm
Copy link
Copy Markdown
Contributor

trueadm commented Nov 3, 2024 •
edited
Loading

Whilst this is better, it still doesn't feel perfect. Ultimately, I think we need to determine this somehow at runtime but let's get this improvement in first.

@dummdidumm dummdidumm merged commit 551284c into main Nov 3, 2024
@dummdidumm dummdidumm deleted the a-tag-namespace-fix branch November 3, 2024 14:04
@github-actions github-actions Bot mentioned this pull request Nov 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@trueadm trueadm trueadm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

#snippet alter rendering behaviour of text inside svg SVG elements not displaying when passed as slot content

3 participants

@dummdidumm @Rich-Harris @trueadm