Skip to content

fix: check options namespace for top level svelte:elements#14101

Merged
dummdidumm merged 1 commit intomainfrom
element-namespace
Nov 1, 2024
Merged

fix: check options namespace for top level svelte:elements#14101
dummdidumm merged 1 commit intomainfrom
element-namespace

Conversation

@dummdidumm
Copy link
Copy Markdown
Member

@dummdidumm dummdidumm commented Nov 1, 2024

We were checking it for nested elements, but not root elements

fixes #13875

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

@dummdidumm
fix: check options namespace for top level svelte:elements
cbc7f52 
We were checking it for nested elements, but not root elements

fixes #13875
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Nov 1, 2024

🦋 Changeset detected

Latest commit: cbc7f52

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Nov 1, 2024 

pnpm add https://pkg.pr.new/svelte@14101

commit: cbc7f52

@dummdidumm dummdidumm merged commit 4ec9986 into main Nov 1, 2024
@dummdidumm dummdidumm deleted the element-namespace branch November 1, 2024 18:09
@github-actions github-actions bot mentioned this pull request Nov 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@trueadm trueadm trueadm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SVG does not rendered with <svelte:element>+<svelte:options namespace="svg">

2 participants

@dummdidumm @trueadm