Skip to content

fix: don't show state_referenced_locally warning on types#13177

Merged
dummdidumm merged 5 commits intomainfrom
fix-state-referenced-locally-types
Sep 10, 2024
Merged

fix: don't show state_referenced_locally warning on types#13177
dummdidumm merged 5 commits intomainfrom
fix-state-referenced-locally-types

Conversation

@paoloricciuti
Copy link
Copy Markdown
Member

@paoloricciuti paoloricciuti commented Sep 9, 2024

Svelte 5 rewrite

Closes #13173

I had to add a ts-ignore because the types for the types declaration are not in the path types and i don't think they are worth adding.

Please note that the Svelte codebase is currently being rewritten for Svelte 5. Changes should target Svelte 5, which lives on the default branch (main).

If your PR concerns Svelte 4 (including updates to svelte.dev.docs), please ensure the base branch is svelte-4 and not main.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Sep 9, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 59f53d0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

dummdidumm
dummdidumm reviewed Sep 10, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inside compiler/index.js#compile we're stripping away type annotations before passing it on to the analysis phase etc - I think the better fix would be to strip those types there, i.e. investigate why they aren't removed within remove_typescript_nodes

Comment thread .changeset/five-suns-roll.md Outdated
@paoloricciuti @dummdidumm
Update .changeset/five-suns-roll.md
a6bb962 
Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
@paoloricciuti paoloricciuti changed the title fix: state_referenced_locally in types declarations fix: don't show state_referenced_locally warning on types Sep 10, 2024
@paoloricciuti
Copy link
Copy Markdown
Member Author

paoloricciuti commented Sep 10, 2024

Inside compiler/index.js#compile we're stripping away type annotations before passing it on to the analysis phase etc - I think the better fix would be to strip those types there, i.e. investigate why they aren't removed within remove_typescript_nodes

Uh i missed this...gonna take a look 😉

@paoloricciuti
Copy link
Copy Markdown
Member Author

paoloricciuti commented Sep 10, 2024

Inside compiler/index.js#compile we're stripping away type annotations before passing it on to the analysis phase etc - I think the better fix would be to strip those types there, i.e. investigate why they aren't removed within remove_typescript_nodes

We were simply missing a visitor for type annotations. Much better fix, thanks

dummdidumm
dummdidumm reviewed Sep 10, 2024
View reviewed changes
Comment thread packages/svelte/src/compiler/phases/1-parse/remove_typescript_nodes.js
@dummdidumm dummdidumm merged commit 941f83b into main Sep 10, 2024
@dummdidumm dummdidumm deleted the fix-state-referenced-locally-types branch September 10, 2024 14:35
@dummdidumm
Copy link
Copy Markdown
Member

dummdidumm commented Sep 10, 2024

If we want to adjust this in the future, an alternative would be to adjust zimmerframe so that if you return null (for example) that this signals to zimmerframe "remove this node"

@paoloricciuti
Copy link
Copy Markdown
Member Author

paoloricciuti commented Sep 10, 2024

If we want to adjust this in the future, an alternative would be to adjust zimmerframe so that if you return null (for example) that this signals to zimmerframe "remove this node"

That would be actually better and useful

@github-actions github-actions Bot mentioned this pull request Sep 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dummdidumm dummdidumm dummdidumm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

state_referenced_locally warning appears on type guard

2 participants

@paoloricciuti @dummdidumm