feat: allow as expressions for bindable props#2372
Conversation
|
@dummdidumm can i ask you where i should put the test here? P.s. if you can give a general rule of thumb on how to determine where to put them it would be great for the next times too 😄 |
|
Personally unsure about this because the type assert looks redundant. The behaviour also slightly deviates from a ts file where the |
Is not something I would personally do but it was pointed out and I think is worth have a safeguard against those who does it. |
|
While I agree with @jasonlyu123 that it's weird to do that, it's still valid TS syntax and we should support it so this property is properly marked as bindable. As for the test: I propose to enhance the |
Added the test...for the future how can i pick between |
|
@dummdidumm the test failing is unrelated to this change...should i update that here? |
|
Yeah you can update it here. |
Oh got it! Thanks |
|
@dummdidumm Can we get a new release with this in it? I appreciate the work you guys put into this! |
As per discussion on discord this change allow for declaring the type of a bindable prop using the
as typeexpressioneg.
i would just need a bit of guidance to determine where to write the test.