fix: balance parentheses in error about wrong content type for action#9513
Merged
Rich-Harris merged 3 commits intosveltejs:masterfrom Mar 30, 2023
danieldiekmeier:patch-2
Merged
fix: balance parentheses in error about wrong content type for action#9513Rich-Harris merged 3 commits intosveltejs:masterfrom danieldiekmeier:patch-2
Rich-Harris merged 3 commits intosveltejs:masterfrom
danieldiekmeier:patch-2
Conversation
🦋 Changeset detectedLatest commit: b7ba460 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
benmccann
reviewed
Mar 26, 2023
| if (!is_form_content_type(event.request)) { | ||
| throw new Error( | ||
| `Actions expect form-encoded data (received ${event.request.headers.get('content-type')}` | ||
| `Actions expect form-encoded data (received ${event.request.headers.get('content-type')})` |
Member
There was a problem hiding this comment.
Another alternative would be to remove the parentheses. I'll leave this as a suggestion to see if the other maintainers have any preference
Suggested change
| `Actions expect form-encoded data (received ${event.request.headers.get('content-type')})` | |
| `Actions expect form-encoded data, but received ${event.request.headers.get('content-type')}` |
benmccann
reviewed
Mar 26, 2023
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
Rich-Harris
approved these changes
Mar 30, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When you send the wrong content type to an action, SvelteKit throws a helpful error, but it's missing the parentheses at the end:
This PR adds it. That's all! Thanks!
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.