Skip to content

add HMR to fallback error pages in dev#9497

Merged
Rich-Harris merged 2 commits intomasterfrom
error-hmr
Mar 24, 2023
Merged

add HMR to fallback error pages in dev#9497
Rich-Harris merged 2 commits intomasterfrom
error-hmr

Conversation

@Rich-Harris
Copy link
Copy Markdown
Member

At present, if you make a change that results in a fallback error page loading (e.g. introducing a syntax error in a +page.server.js), SvelteKit doesn't recover from the error.

With this change, HMR is activated, meaning that when you fix the error the page reloads. Together with #9440, this makes debugging much more pleasant.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 23, 2023

🦋 Changeset detected

Latest commit: a1f3fe9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Copy Markdown
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple, clever solution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants