Skip to content

fix: resolve user files with drive letter on Windows#15793

Merged
teemingc merged 2 commits into
mainfrom
fix-drive-letter
May 4, 2026
Merged

fix: resolve user files with drive letter on Windows#15793
teemingc merged 2 commits into
mainfrom
fix-drive-letter

Conversation

@teemingc

@teemingc teemingc commented May 4, 2026

Copy link
Copy Markdown
Member

Hope this helps fix sveltejs/vite-plugin-svelte#1328 (comment)

EDIT: It does!

We don't need the path.posix.resolve variant since to_fs already posixifies the path later (that code was also written almost 4 years ago). Using it causes Windows to omit the letter drive, which misaligns with Vite's own file resolution. I've verified it fixes the issue by running CI tests with it in sveltejs/vite-plugin-svelte#1328


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@changeset-bot

changeset-bot Bot commented May 4, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: e9ff8c2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@svelte-docs-bot

Copy link
Copy Markdown

@teemingc teemingc merged commit e547ec1 into main May 4, 2026
29 checks passed
@teemingc teemingc deleted the fix-drive-letter branch May 4, 2026 18:08
@github-actions github-actions Bot mentioned this pull request May 4, 2026
teemingc pushed a commit that referenced this pull request May 5, 2026
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @sveltejs/kit@2.59.1

### Patch Changes

- fix: resolve paths to route files with the letter drive on Windows
([#15793](#15793))

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants