🦋 Changeset detected

Latest commit: c7d3ea7

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Added svelte5 to create-svelte tests and lint is failing in created projects for array reactivity in sverdle

https://github.com/sveltejs/kit/actions/runs/10439353949/job/28907856687?pr=12586#step:8:111

Added svelte5 to create-svelte tests and lint is failing in created projects for array reactivity in sverdle

Oh, yeah, I guess we'll have to fix that. I might have missed the error in the logs, but all I see is:

   ❯ test/check.js  (52 tests | 2 failed) 85441ms
     × lint > default-checkjs-svelte5
       → Command failed: pnpm lint
  
     × lint > default-typescript-svelte5
       → Command failed: pnpm lint

It'd be nice if it showed how it failed

We could simply revert the changes to check.js for an easy fix. It's a pretty short-term thing that we'll have multiple versions of Svelte in the CLI, so I'm not as worried about making sure we test both of them

iirc the logs were too verbose, this is what it logs locally:

/home/xxxx/develop/sveltejs/kit/.test-tmp/create-svelte/default-checkjs-svelte5/src/routes/sverdle/+page.svelte
  47:20  error  Properties of objects and arrays are not reactive unless in runes mode. Changes to this property will not cause the reactive statement to update(reactive_declaration_non_reactive_property)  svelte/valid-compile

maybe it's possible to change the code in question so it works without this error? I think it is important that create-svelte creates working projects in all permutations

Oh yeah. If it's an issue affecting whether it works we'll have to fix it. I thought it was just a style issue

the error does look like it's a false positive though:

	$: {
		classnames = {};
		description = {};

		data.answers.forEach((answer, i) => {
			const guess = data.guesses[i];

			for (let i = 0; i < 5; i += 1) {
				// Properties of objects and arrays are not reactive unless in runes mode.
				// Changes to this property will not cause the reactive statement to
				// update(reactive_declaration_non_reactive_property) eslint(svelte/valid-compile)
				const letter = guess[i];
				//             ^^^^^^^^

				if (answer[i] === "x") {
					classnames[letter] = "exact";
					description[letter] = "correct";
				} else if (!classnames[letter]) {
					classnames[letter] = answer[i] === "c" ? "close" : "missing";
					description[letter] = answer[i] === "c" ? "present" : "absent";
				}
			}
		});
	}

the project builds and works as expected too

edit: the description of the error isn't wrong, but it seems more like it's wrongly presented as an error instead of a warning

We probably want the whole sverdle refactored to make use of runes as a showcase for svelte5.

cc @Rich-Harris

Was introduced through sveltejs/svelte#12824, I personally think this will cause to many false positives and needs to be tweaked / reverted, but we'll see. Either way it's unrelated to this PR