Skip to content

chore: setup package provenance#12567

Merged
benmccann merged 1 commit intomainfrom
provenance
Aug 9, 2024
Merged

chore: setup package provenance#12567
benmccann merged 1 commit intomainfrom
provenance

Conversation

@benmccann
Copy link
Copy Markdown
Member

@benmccann benmccann commented Aug 9, 2024

No description provided.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Aug 9, 2024

🦋 Changeset detected

Latest commit: 17a2d95

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@sveltejs/adapter-cloudflare-workers Patch
@sveltejs/adapter-cloudflare Patch
@sveltejs/adapter-netlify Patch
@sveltejs/adapter-static Patch
@sveltejs/adapter-vercel Patch
create-svelte Patch
@sveltejs/adapter-auto Patch
@sveltejs/adapter-node Patch
@sveltejs/enhanced-img Patch
svelte-migrate Patch
@sveltejs/package Patch
@sveltejs/amp Patch
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@benmccann benmccann merged commit 4930a84 into main Aug 9, 2024
@benmccann benmccann deleted the provenance branch August 9, 2024 16:24
@github-actions github-actions bot mentioned this pull request Aug 9, 2024
Merged
@WarningImHack3r
Copy link
Copy Markdown

WarningImHack3r commented Aug 9, 2024

@benmccann you duplicated the "publishConfig" key for the Cloudflare adapter (just so you know)

@benmccann benmccann mentioned this pull request Aug 9, 2024
Open
benmccann
benmccann commented Aug 9, 2024
View reviewed changes
packages/adapter-cloudflare/package.json
@@ -56,5 +56,8 @@
},
"publishConfig": {
Copy link
Copy Markdown
Member Author

@benmccann benmccann Aug 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're on crack, github. this code doesn't exist:

kit/packages/adapter-cloudflare/package.json

Line 57 in 2b19df3

"publishConfig": {

wtf is happening here??

Copy link
Copy Markdown
Member

@Conduitry Conduitry Aug 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2b19df3#diff-1ac6ebb9247195e0dfa0f18975077643b0e0743c80cd8588b0084f5252cecec0 Changesets removed this when it bumped the version number for the release.

@benmccann
Copy link
Copy Markdown
Member Author

benmccann commented Aug 9, 2024

okay, figured out the mystery. changesets automatically deleted the duplicate 😱 but that's fine because we didn't need the other one anyway. thanks for pointing this out!

@Conduitry
Copy link
Copy Markdown
Member

Conduitry commented Aug 9, 2024

Changesets presumably deleted the duplicate because JSON.parse() seems to silently ignore all but the last instance of a duplicated key. Thanks, javascript. That's an interesting choice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Conduitry Conduitry Conduitry left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@benmccann @WarningImHack3r @Conduitry