Skip to content

Validate local git repo when ignoring files#4965

Merged
ferrarimarco merged 5 commits into
mainfrom
check-git-repo-ignored
Dec 18, 2023
Merged

Validate local git repo when ignoring files#4965
ferrarimarco merged 5 commits into
mainfrom
check-git-repo-ignored

Conversation

@ferrarimarco

@ferrarimarco ferrarimarco commented Dec 11, 2023

Copy link
Copy Markdown
Collaborator

Related to #4956

Proposed Changes

  1. Check if the local Git repository is valid if we enable IGNORE_GITIGNORED_FILES because we rely on git check-ignore in that case.

Readiness Checklist

Author/Contributor

  • I included all the needed documentation for this change.
  • I provided the necessary tests.

Reviewing Maintainer

  • Label as breaking if this is a large, fundamental change.
  • Label as either: automation, bug, documentation, enhancement, infrastructure.

BEGIN_COMMIT_OVERRIDE
feat: validate local git repo when ignoring files (#4965)
END_COMMIT_OVERRIDE

@ferrarimarco ferrarimarco added the O: backlog 🤖 Backlog, stale ignores this label label Dec 14, 2023
@ferrarimarco

Copy link
Copy Markdown
Collaborator Author

@zkoppert going ahead with this simple change. :)

@ferrarimarco ferrarimarco merged commit ae70816 into main Dec 18, 2023
@ferrarimarco ferrarimarco deleted the check-git-repo-ignored branch December 18, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request O: backlog 🤖 Backlog, stale ignores this label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants