Skip to content

refactor: dual cjs and esm build, nodenext readiness#950

Merged
iddan merged 15 commits into
masterfrom
feat/dual-builds
Dec 7, 2025
Merged

refactor: dual cjs and esm build, nodenext readiness#950
iddan merged 15 commits into
masterfrom
feat/dual-builds

Conversation

@iddan

@iddan iddan commented Dec 4, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator
  • Fixed unit.d.ts definition
  • Defined dual builds for all packages
  • Added ESM support for package resolver (using custom build see in changed files)
  • Fixed augmentation in ESM envs
  • in addition: created a TypeScript version of local e2e, which runs the code in a container and doesn't interrupt
  • Added Node 22 and 24 to the test matrix

@iddan iddan marked this pull request as draft December 4, 2025 14:23
@codecov

codecov Bot commented Dec 4, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.94%. Comparing base (ba858b7) to head (a83d362).
⚠️ Report is 17 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #950      +/-   ##
==========================================
+ Coverage   92.52%   92.94%   +0.41%     
==========================================
  Files          25       26       +1     
  Lines         589      595       +6     
  Branches       99       99              
==========================================
+ Hits          545      553       +8     
+ Misses         35       33       -2     
  Partials        9        9
Flag Coverage Δ
core.unit 93.44% <ø> (ø)
di.inversify 93.61% <ø> (ø)
di.nestjs 87.25% <ø> (ø)
doubles.jest 100.00% <ø> (ø)
doubles.sinon 100.00% <ø> (ø)
doubles.vitest 100.00% <ø> (ø)
unit 84.00% <100.00%> (+6.72%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@iddan iddan force-pushed the feat/dual-builds branch 2 times, most recently from f9684ee to fead383 Compare December 4, 2025 16:08
@iddan iddan changed the title Feat/dual builds Dual Builds Dec 4, 2025
@iddan iddan force-pushed the feat/dual-builds branch 2 times, most recently from b9d51b3 to 58c20fd Compare December 4, 2025 17:24
@omermorad omermorad changed the title Dual Builds refactor: dual cjs and esm build, nodenext readiness Dec 4, 2025
@omermorad omermorad force-pushed the feat/dual-builds branch 2 times, most recently from 0db5b17 to f62ff8a Compare December 6, 2025 18:38
@iddan iddan self-assigned this Dec 7, 2025
@iddan iddan force-pushed the feat/dual-builds branch 2 times, most recently from 9629a88 to 299401e Compare December 7, 2025 17:20
iddan added 14 commits December 7, 2025 19:22
@iddan
fix(doubles): use relative imports in type augmentation
3c21716
@iddan
feat(unit): export Mocked type from @suites/unit
14fb2cc
@iddan
feat(types): add dual CJS/ESM build output
016be23
@iddan
feat(di): add dual CJS/ESM build output
f21613b
@iddan
feat(doubles): add dual CJS/ESM build output
597f722
@iddan
feat(core): add dual CJS/ESM build output
1d2d9e3
@iddan
refactor(unit): restructure package resolver with IoC composition
8021c82
@iddan
feat(unit): add dual CJS/ESM build with ESM package resolver
9528e85
@iddan
refactor(e2e): replace shell script with TypeScript runner
f64ac80
@iddan
fix: add Jest moduleNameMapper for workspace dependencies
c039a9b
@iddan
fix(e2e): update test configurations and dependencies
4ca12a0
@iddan
feat(e2e): add ESM module tests for Jest and Vitest
ba1e20e
@iddan
feat(ci): add ESM e2e tests to workflow matrix
a7824ee
@iddan
refactor: update pnpm-lock.yaml
b0e6021
@iddan iddan marked this pull request as ready for review December 7, 2025 17:26
@iddan iddan force-pushed the feat/dual-builds branch 2 times, most recently from 80394d1 to fb58fd1 Compare December 7, 2025 18:32
@iddan iddan merged commit d8a2389 into master Dec 7, 2025
50 checks passed
@iddan iddan deleted the feat/dual-builds branch December 7, 2025 18:50
@nelson6e65

nelson6e65 commented Dec 12, 2025

Copy link
Copy Markdown

Hi. When will be released this? 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@iddan iddan

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@iddan @nelson6e65