fix: correctly handle differing any types in fn invocation#180
Merged
benbellick merged 1 commit intomainfrom Dec 12, 2025
Merged
fix: correctly handle differing any types in fn invocation#180benbellick merged 1 commit intomainfrom
any types in fn invocation#180benbellick merged 1 commit intomainfrom
Conversation
cafb446 to
15a570a
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #180 +/- ##
=======================================
Coverage 68.78% 68.79%
=======================================
Files 45 45
Lines 10365 10367 +2
=======================================
+ Hits 7130 7132 +2
Misses 2886 2886
Partials 349 349 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
benbellick
commented
Dec 12, 2025
| err := extensions.ValidateConstrainedAnyTypeConsistency(params, args, nil) | ||
| require.Error(t, err, "nested any1 mismatch should fail") | ||
| require.Contains(t, err.Error(), "type parameter any1 cannot be both") | ||
| }) |
Member
Author
There was a problem hiding this comment.
Btw, I can see a case for consolidating all of the above tests into a for loop and calling it one test. This is something we could consider in a later PR though.
kadinrabo
approved these changes
Dec 12, 2025
Contributor
kadinrabo
left a comment
There was a problem hiding this comment.
Great work with the extra tests, looks good to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #178