Skip to content

feat: unify column data retrieval for aggregate test cases#123

Merged
EpsilonPrime merged 5 commits intosubstrait-io:mainfrom
srikrishnak:get-column-data
Mar 2, 2025
Merged

feat: unify column data retrieval for aggregate test cases#123
EpsilonPrime merged 5 commits intosubstrait-io:mainfrom
srikrishnak:get-column-data

Conversation

@srikrishnak
Copy link
Copy Markdown
Contributor

No description provided.

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.94%. Comparing base (b0cb727) to head (c4faefd).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #123      +/-   ##
==========================================
+ Coverage   63.89%   63.94%   +0.05%     
==========================================
  Files          44       44              
  Lines       10923    10940      +17     
==========================================
+ Hits         6979     6996      +17     
  Misses       3629     3629              
  Partials      315      315              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread testcases/parser/nodes.go
Comment thread testcases/parser/nodes.go Outdated
add a test case for all aggregate formats
@srikrishnak srikrishnak requested a review from scgkiran February 28, 2025 10:37
Copy link
Copy Markdown
Member

@EpsilonPrime EpsilonPrime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we're in here do we want to add support for both aggregate formats to GetArgTypes?

Comment thread testcases/parser/parse_test.go
@srikrishnak
Copy link
Copy Markdown
Contributor Author

While we're in here do we want to add support for both aggregate formats to GetArgTypes?
Enhanced the test case to check GetArgTypes. It works correctly for all aggregate formats

@srikrishnak srikrishnak requested a review from EpsilonPrime March 1, 2025 02:40
@EpsilonPrime EpsilonPrime merged commit 32ce783 into substrait-io:main Mar 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants