feat: add is_null support in testfile parser#120
Conversation
Add nullable parameter to literal creation utils
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #120 +/- ##
==========================================
+ Coverage 63.79% 63.90% +0.11%
==========================================
Files 44 44
Lines 10917 10921 +4
==========================================
+ Hits 6964 6979 +15
+ Misses 3638 3627 -11
Partials 315 315 ☔ View full report in Codecov by Sentry. |
|
|
||
| func NewBool(value bool) expr.Literal { | ||
| return expr.NewPrimitiveLiteral[bool](value, false) | ||
| func NewBool(value bool, nullable bool) expr.Literal { |
There was a problem hiding this comment.
These changes while straightforward are going to break a lot of existing code. Two alternates would be to add an additional function with the new behavior (NewNullBool creating a nullable Bool or NewNullableBool with the option similar to what is implemented here). A third is to actually make this a breaking change which would cause a version bump. A fourth option would be to add a new method to expr.Literal that would change the nullability to be set.
There was a problem hiding this comment.
will mark this as breaking change
Add nullable parameter to literal creation utils
Literal creation helpers now include an additional boolean parameter for nullability.