Skip to content

feat: add support for NewDecimalFromApdDecimal#119

Merged
scgkiran merged 1 commit intosubstrait-io:mainfrom
scgkiran:apd_decimal
Feb 13, 2025
Merged

feat: add support for NewDecimalFromApdDecimal#119
scgkiran merged 1 commit intosubstrait-io:mainfrom
scgkiran:apd_decimal

Conversation

@scgkiran
Copy link
Copy Markdown
Contributor

No description provided.

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 12, 2025

Codecov Report

Attention: Patch coverage is 84.21053% with 3 lines in your changes missing coverage. Please review.

Project coverage is 63.79%. Comparing base (261dc94) to head (6c48771).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
literal/utils.go 50.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #119      +/-   ##
==========================================
+ Coverage   63.77%   63.79%   +0.01%     
==========================================
  Files          44       44              
  Lines       10904    10917      +13     
==========================================
+ Hits         6954     6964      +10     
- Misses       3636     3638       +2     
- Partials      314      315       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scgkiran scgkiran requested a review from anshuldata February 13, 2025 01:29
@scgkiran scgkiran merged commit e64c786 into substrait-io:main Feb 13, 2025
@scgkiran scgkiran deleted the apd_decimal branch February 13, 2025 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants