Skip to content

feat: update VirtualTableReadRel.CopyWithExpressionRewrite to rewrite literal values#113

Merged
EpsilonPrime merged 3 commits intosubstrait-io:mainfrom
EpsilonPrime:virtual_rewrites
Feb 5, 2025
Merged

feat: update VirtualTableReadRel.CopyWithExpressionRewrite to rewrite literal values#113
EpsilonPrime merged 3 commits intosubstrait-io:mainfrom
EpsilonPrime:virtual_rewrites

Conversation

@EpsilonPrime
Copy link
Copy Markdown
Member

No description provided.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 63.60%. Comparing base (60cc74f) to head (78a83dd).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
plan/relations.go 80.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #113      +/-   ##
==========================================
+ Coverage   63.53%   63.60%   +0.06%     
==========================================
  Files          44       44              
  Lines       10858    10873      +15     
==========================================
+ Hits         6899     6916      +17     
+ Misses       3644     3639       -5     
- Partials      315      318       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread plan/relations.go Outdated
Copy link
Copy Markdown
Contributor

@anshuldata anshuldata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@EpsilonPrime EpsilonPrime merged commit e1e6157 into substrait-io:main Feb 5, 2025
@EpsilonPrime EpsilonPrime deleted the virtual_rewrites branch February 5, 2025 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants