Fix declaration-block-no-redundant-longhand-properties false negative for font-synthesis#7214
Merged
Fix declaration-block-no-redundant-longhand-properties false negative for font-synthesis#7214
declaration-block-no-redundant-longhand-properties false negative for font-synthesis#7214Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: #7213 (comment) (and transitively, #7200 (comment)).
First, do we like this custom resolver? It is a bit long!
Secondly,
font-synthesisactually supports four longhand properties. However,font-synthesis-positioncurrently has 0.41% adoption according to caniuse, which is far too small for it to be relevant. I've elected to not include it for now; however, we could also include it if we think that better future-proofs the rule?