Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6961.
I apologize for how large this change is 😅 I'm not sure if this is easier to review (since it is clean + accomplishes it in one go), or if we'd prefer one that splits them up piecemeal (e.g. into sections) - let me know what we'd prefer!
I'll quickly explain the methodology for this PR:
lib/rules/*for each deprecated testlib/rules/index.jscolor-namedforcolor-hex-caseandnumber-max-precisionforindentation).skip(have left comments in the review)indentation-specific behaviour (it being last); I deleted these!indentation)