⚠️ No Changeset found

Latest commit: 8090055

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

This PR is packaged and the instant preview is available (8090055). View the demo website.

Install it locally:

npm i -D https://pkg.pr.new/stylelint@8090055

The ecosystem run flagged up a failed test in stylelint-config-wikimedia:

test/fixtures/default/invalid.css
  197:2  ✖  Needless disable for "property-no-unknown"  --report-needless-disables

✖ 1 problem (1 error, 0 warnings)

Fixture lines:

.k {
	/* stylelint-disable-next-line no-invalid-double-slash-comments, property-no-unknown */
	//color: #fff;
    /* .. */
}

I dug into it and believe it's fine, as it highlights a false positive we've fixed in property-no-unknown.

Demo of 17.3.0 vs Demo of main.

I've pushed a commit here (d15df85) to add a changelog entry.

@romainmenke If you're still online and have time, a 2nd pair of eyes and approval would be great!

Thank you for double-checking.

I think it is fine considering our policy that rules should focus on a single issue and should not overlap. The leading // is covered by another rule.

Yes, I had the same thought. We have no-invalid-double-slash-comments for that.

I'll continue with the release.