Fix no-descending-specificity performance#7026
Merged
romainmenke merged 3 commits intomainfrom Jul 3, 2023
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #6869
This rule warned multiple times for the same selector.
It would emit one warning for each selector with lower specificity that preceded the current selector.
I don't think this is very useful as it just causes extra noise.
With this change this rule will only emit a single warning for each selector.
It will always reference the earliest other selector with lower specificity.
All these extra warnings came at a cost.
fewer warnings -> faster execution.
I've also added extra tests to cover this scenario.
before :
after :
The excessive number of warnings is the result of the duplicate CSS in the test source.
Ideally we would have a large, but well formed and realistic benchmark source.