Fix unit-no-unknown false positives for unicode-range descriptors#6892
Merged
romainmenke merged 2 commits intomainfrom Jun 5, 2023
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6891
I forgot about
<urange>productions when migrating rules to@csstools/css-tokenizer.Parsing
<urange>requires special handling and should only be done when inside a context that expects such values.I've added a helper (
isUnicodeRangeDescriptor) to make it easier for rules to skip@font-face { unicode-range: U+0100-024F; }