feat: inline fs.ts types to remove node:fs dependency#1198
Merged
Conversation
Co-authored-by: streamich <9773803+streamich@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Inline
feat: inline fs.ts types to remove node:fs dependency
Sep 24, 2025
src/vendor/node/fs.ts file
Contributor
|
🎉 This PR is included in version 4.45.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR inlines the type definitions from
node:fsin thesrc/vendor/node/fs.tsfile to eliminate the implicit dependency warning from tslint.Changes
The file previously imported types directly from Node.js:
This has been replaced with inlined type definitions:
Benefits
no-implicit-dependenciestslint error fornode:fsVerification
symlink.Typecontinue to workThe change is minimal and surgical, affecting only the type definitions while maintaining the same functionality and type safety.
Fixes #1197.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.