fix: allow setting custom file types beyond S_IFREG and S_IFDIR#1082
Merged
G-Rath merged 1 commit intostreamich:masterfrom Jan 1, 2025
Merged
fix: allow setting custom file types beyond S_IFREG and S_IFDIR#1082G-Rath merged 1 commit intostreamich:masterfrom
G-Rath merged 1 commit intostreamich:masterfrom
Conversation
Contributor
Author
|
Fixed up the formatting! |
Contributor
Author
|
@G-Rath if you could take a look at this when you get a sec, that'd be awesome! |
G-Rath
reviewed
Dec 30, 2024
Collaborator
G-Rath
left a comment
There was a problem hiding this comment.
thanks looks good overall, just have a couple of questions
Contributor
Author
|
@G-Rath I appreciate the good review! All fixes have been done, and I made the |
G-Rath
reviewed
Dec 31, 2024
Prior to this change, the `mode` argument to `Node` and `Volume` was only used to set the file permissions.
G-Rath
approved these changes
Jan 1, 2025
github-actions Bot
pushed a commit
that referenced
this pull request
Jan 1, 2025
## [4.15.3](v4.15.2...v4.15.3) (2025-01-01) ### Bug Fixes * allow setting custom file types beyond S_IFREG and S_IFDIR ([#1082](#1082)) ([24da3e7](24da3e7))
Contributor
|
🎉 This PR is included in version 4.15.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this change, the
modeargument toNodeandVolumewas only used to set the file permissions.