Skip to content

feat: support stream as source in promises version of writeFile#1069

Merged
G-Rath merged 1 commit intostreamich:masterfrom
SoulKa:feature/#1068-stream-source-in-promises-writefile
Oct 13, 2024
Merged

feat: support stream as source in promises version of writeFile#1069
G-Rath merged 1 commit intostreamich:masterfrom
SoulKa:feature/#1068-stream-source-in-promises-writefile

Conversation

@SoulKa
Copy link
Copy Markdown
Contributor

@SoulKa SoulKa commented Oct 10, 2024

Now supporting streams as writeFile() data source in the Promises API, which makes it more compliant to the Node.js Promises API.

What's still missing is the support for AsyncIterable and Iterable. I can implement them as well if this PR gets approved.

Closes #1068

@SoulKa SoulKa force-pushed the feature/#1068-stream-source-in-promises-writefile branch 3 times, most recently from 767b585 to 347abc0 Compare October 10, 2024 11:50
@SoulKa SoulKa force-pushed the feature/#1068-stream-source-in-promises-writefile branch from 347abc0 to 449035d Compare October 10, 2024 11:52
@SoulKa SoulKa changed the title #1068 - support stream as source in Promises writeFile Feat: support stream as source in Promises writeFile Oct 10, 2024
@G-Rath G-Rath changed the title Feat: support stream as source in Promises writeFile feat: support stream as source in promises version of writeFile Oct 13, 2024
@G-Rath G-Rath merged commit 11f8a36 into streamich:master Oct 13, 2024
github-actions bot pushed a commit that referenced this pull request Oct 13, 2024
# [4.14.0](v4.13.0...v4.14.0) (2024-10-13)

### Features

* support stream as source in promises version of `writeFile` ([#1069](#1069)) ([11f8a36](11f8a36))
@github-actions
Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 4.14.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@SoulKa SoulKa deleted the feature/#1068-stream-source-in-promises-writefile branch October 13, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support Stream as source in Promises writeFile

2 participants