Skip to content

Update build system#3630

Merged
patrick91 merged 1 commit intomainfrom
update/build-system
Sep 13, 2024
Merged

Update build system#3630
patrick91 merged 1 commit intomainfrom
update/build-system

Conversation

@patrick91
Copy link
Copy Markdown
Member

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have skipped reviewing this pull request. We don't review packaging changes - Let us know if you'd like us to change this.

@botberry
Copy link
Copy Markdown
Member

Apollo Federation Subgraph Compatibility Results

Federation 1 Support Federation 2 Support
_service🟢
@key (single)🟢
@key (multi)🟢
@key (composite)🟢
repeatable @key🟢
@requires🟢
@provides🟢
federated tracing🔲
@link🟢
@shareable🟢
@tag🟢
@override🟢
@inaccessible🟢
@composeDirective🟢
@interfaceObject🟢

Learn more:

@botberry
Copy link
Copy Markdown
Member

Hi, thanks for contributing to Strawberry 🍓!

We noticed that this PR is missing a RELEASE.md file. We use that to automatically do releases here on GitHub and, most importantly, to PyPI!

So as soon as this PR is merged, a release will be made 🚀.

Here's an example of RELEASE.md:

Release type: patch

Description of the changes, ideally with some examples, if adding a new feature.

Release type can be one of patch, minor or major. We use semver, so make sure to pick the appropriate type. If in doubt feel free to ask :)

Here's the tweet text:

🆕 Release (next) is out! Thanks to @patrick91 for the PR 👏

Get it here 👉 https://strawberry.rocks/release/(next)

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.76%. Comparing base (66fc6dc) to head (af46930).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3630   +/-   ##
=======================================
  Coverage   96.76%   96.76%           
=======================================
  Files         521      521           
  Lines       33732    33732           
  Branches     5627     5627           
=======================================
  Hits        32640    32640           
  Misses        860      860           
  Partials      232      232           

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Sep 13, 2024

CodSpeed Performance Report

Merging #3630 will not alter performance

Comparing update/build-system (af46930) with main (66fc6dc)

Summary

✅ 15 untouched benchmarks

@patrick91 patrick91 merged commit 08cc1c2 into main Sep 13, 2024
@patrick91 patrick91 deleted the update/build-system branch September 13, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants