Test: Remove source map generation from webpack automock-loader#32115
Merged
valentinpalkovic merged 1 commit intonextfrom Jul 24, 2025
Merged
Conversation
|
View your CI Pipeline Execution ↗ for commit d901add
☁️ Nx Cloud last updated this comment at |
yannbf
approved these changes
Jul 24, 2025
11 tasks
This was referenced Aug 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #
What I did
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>Greptile Summary
This PR simplifies the webpack automock loader by removing source map generation. The change converts the loader from using Webpack's asynchronous callback pattern (
this.async()andcallback()) to a synchronous return pattern. Previously, the loader would callcallback(null, mocked.toString(), mocked.generateMap())to return both the transformed code and source maps. Now it directly returnsmocked.toString(), eliminating source map generation entirely.The automock functionality itself remains unchanged - the
getAutomockCodefunction from@vitest/mockerstill handles the core transformation logic for creating mocked modules. This loader is part of Storybook's webpack preprocessing pipeline and is used to automatically generate mocks for modules during testing scenarios. The change streamlines the loader implementation by removing unnecessary complexity around source map handling, which may not be critical for automocked test modules.PR Description Notes:
Confidence score: 4/5
code/core/src/core-server/presets/webpack/loaders/webpack-automock-loader.tsshould be reviewed to ensure the synchronous pattern works correctly with webpack's loader API