Core: Remove maximum-scale=1 from viewport meta tag#31283
Merged
ghengeveld merged 6 commits intostorybookjs:nextfrom May 8, 2025
Merged
Core: Remove maximum-scale=1 from viewport meta tag#31283ghengeveld merged 6 commits intostorybookjs:nextfrom
ghengeveld merged 6 commits intostorybookjs:nextfrom
Conversation
Contributor
There was a problem hiding this comment.
LGTM
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
|
View your CI Pipeline Execution ↗ for commit 1b26019.
☁️ Nx Cloud last updated this comment at |
Sidnioulz
reviewed
May 1, 2025
Member
Sidnioulz
left a comment
There was a problem hiding this comment.
See #31272 (comment). We'll need to check that the original bug no longer exists.
Contributor
|
@ghengeveld Can you please verify that removing the attribute doesn't reintroduce the issues closed by this PR? |
…obile, and update element sizing accordingly
Sidnioulz
reviewed
May 7, 2025
ghengeveld
approved these changes
May 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #31272
What I did
Removed
maximum-scale=1from the viewport meta tag in the Storybook manager UI. This property was originally introduced to prevent mobile browsers from zooming in onto a focused input field, specifically the search field. To remedy the original issue, the font size for the search input was bumped to 16px on mobile, and element padding/sizing for mobile has been updated accordingly.Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>Greptile Summary
Removed 'maximum-scale=1' from the viewport meta tag in the HTML template to improve accessibility, allowing users to zoom content up to 200% as per WCAG 2.1 Success Criterion 1.4.4.
code/core/assets/server/template.ejsto remove maximum-scale restriction, enabling zoom functionality for users with visual impairments