Skip to content

UI: Improve Button layout and props#23356

Merged
ndelangen merged 38 commits intorelease/7.2from
charles/update-button
Jul 14, 2023
Merged

UI: Improve Button layout and props#23356
ndelangen merged 38 commits intorelease/7.2from
charles/update-button

Conversation

@cdedreuille
Copy link
Copy Markdown
Contributor

@cdedreuille cdedreuille commented Jul 7, 2023

What I did

The Button component had a lot of variants that were not used and confusing. Some versions were also missing compared to the design. This PR is an attempt to add the new props for the <Button /> component while still maintaining backward compatibility with versions that uses the old props.

  • Add new props + styling for the <Button /> component
  • Add depreciated mention for all props we would like to remove in 8.0
  • Update documentation to improve visibility on how to use the Button component.

How to test

  1. Run a sandbox for template, e.g. yarn task --task sandbox --start-from auto --template react-vite/default-ts
  2. Open Storybook in your browser
  3. Access the Button story

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@cdedreuille cdedreuille added the maintenance User-facing maintenance tasks label Jul 10, 2023
@cdedreuille cdedreuille changed the title Button V2 Cleanup - Improved Button layout and props Jul 10, 2023
@cdedreuille cdedreuille changed the title Cleanup - Improved Button layout and props Cleanup: Improved Button layout and props Jul 10, 2023
@cdedreuille cdedreuille changed the title Cleanup: Improved Button layout and props UI: Improve Button layout and props Jul 10, 2023
@socket-security
Copy link
Copy Markdown

socket-security Bot commented Jul 11, 2023

No top level dependency changes detected. Learn more about Socket for GitHub ↗︎

@ndelangen ndelangen self-assigned this Jul 12, 2023
@cdedreuille cdedreuille marked this pull request as ready for review July 12, 2023 14:17
@cdedreuille cdedreuille requested a review from ndelangen July 12, 2023 14:18
@cdedreuille cdedreuille changed the base branch from next to release/7.2 July 12, 2023 15:10
@ndelangen ndelangen merged commit 29be84d into release/7.2 Jul 14, 2023
@ndelangen ndelangen deleted the charles/update-button branch July 14, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:normal maintenance User-facing maintenance tasks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants