Addon API: Add experimental page addon type#23307
Merged
ndelangen merged 37 commits intorelease/7.2from Jul 13, 2023
Merged
Conversation
…ignores your selection
…/storybook into norbert/page-addons-refactor
Base automatically changed from
norbert/ui-tabs-types-improvements
to
release/7.2
July 6, 2023 22:29
tmeasday
requested changes
Jul 11, 2023
Member
…ion.tsx Co-authored-by: Tom Coleman <tom@chromatic.com>
…re no longer needed. This is not a breaking change, just logs a warning from react as far as i can see
page addon type
shilman
reviewed
Jul 11, 2023
Member
shilman
left a comment
There was a problem hiding this comment.
During the review you mentioned that there is a breaking TS change where Addon_Type's type field is now required. Please add this to MIGRATION.md.
I love the use of experimental_ in the name. Playwright also does this and I think it's a great convention -- we should do more.
tmeasday
reviewed
Jul 12, 2023
tmeasday
reviewed
Jul 12, 2023
Member
Author
|
@shilman I don't think the I did end up writing some migration guide bits for the increased strictness of the manager-api |
tmeasday
reviewed
Jul 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What I did
page(prefix with experimental for now)/even if there's no query/settingswas before)How to test
/: expect the story to be shown/settings/about: expect the about page to be shown/debugger: expect the debugger panel to be showndebuggerpage : expect the route to change, and the first story to be shownI have done the best I can to have some of this also make sense for the mobile view, but this is really up for grabs. We need to determine what to do regarding pages for mobile.
Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:mergedorci:dailyGH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]