@Cliffback - the pipeline is failing atm. Mind having a look? 🙏

Hmm... Stuggling to make the tests pass.

I get this currently:

but if i add the export to compiler/index.ts and i import stubComponentCompilerMeta from there I then get:

But the function is already bundled, and works fine in actual use, so seems to be just a type issue

Any suggestions, @johnjenkins?

not off the top of my head. I would think however, it probably makes most sense if this object can instead be exported from the stencil/core/testing dir (e.g from ./src/testing/mocks.ts) - I know that'd take some re-working within Stencil though.

not off the top of my head. I would think however, it probably makes most sense if this object can instead be exported from the stencil/core/testing dir (e.g from ./src/testing/mocks.ts) - I know that'd take some re-working within Stencil though.

Yeah. Like moving the stub-file from its current location, and into the mocks-file, and rewriting internal references to it in Stencil, or working with the bundler to keep its location but then include it in mocks.ts, or something like that?

Yeah. Like moving the stub-file from its current location, and into the mocks-file, and rewriting internal references to it in Stencil, or working with the bundler to keep its location but then include it in mocks.ts, or something like that?

Option 1 I think? Obvs don't know if there are any wider repercussions to that

Yeah. Like moving the stub-file from its current location, and into the mocks-file, and rewriting internal references to it in Stencil, or working with the bundler to keep its location but then include it in mocks.ts, or something like that?

Option 1 I think? Obvs don't know if there are any wider repercussions to that

I'll give it a go!

For the API, does it make sense to export the stubComponentCompilerMeta as mockComponent for external use? That's at least what i use it for in my code when it comes to it.

@johnjenkins I think it actually was as simple as not just reexporting, but explicitly importing and exporting on different lines. I at least managed to pass the failing command locally. Perhaps restart the workflow to see if it passes now?

For the API, does it make sense to export the stubComponentCompilerMeta as mockComponent for external use? That's at least what i use it for in my code when it comes to it.

I think mockComponentMeta is a bit more descriptive?

@johnjenkins I think it actually was as simple as not just reexporting, but explicitly importing and exporting on different lines. I at least managed to pass the failing command locally. Perhaps restart the workflow to see if it passes now?

Aside from formatting / linting it looks happier!

mockComponentMeta

Aggreed

Aside from formatting / linting it looks happier!

Awesome. Will fix linting and rename to mockCompilerMeta

@johnjenkins Should be good now. Is PR title okay?

@johnjenkins Should be good now. Is PR title okay?

:D - npm run prettier && npm run lint --fix

Sorry, forgot to run prettier as well, should be updated now.