chore(typescript): update typescript to version 5.9.2#6397
Merged
OS-jacobbell merged 6 commits intomainfrom Oct 9, 2025
Merged
chore(typescript): update typescript to version 5.9.2#6397OS-jacobbell merged 6 commits intomainfrom
OS-jacobbell merged 6 commits intomainfrom
Conversation
Fix new type errors. Add types array to tsconfig.json to fix a new issue with dts-bundle-generator + babel. (timocov/dts-bundle-generator#347)
Contributor
|
hey @OS-jacobbell - think this all looks fine. |
Contributor
Author
|
Changed HTMLStencilElement to omit Updated Node version for support of updated typescript. Typed arrays no longer inheriting from ArrayBuffer was a breaking change for Node. For some reason import syntax stopped being compiled to require syntax in the bundler tests, so I changed it to |
johnjenkins
reviewed
Oct 6, 2025
…r typescript 5.9 compatibility Omit autocorrect from HTMLElement and redefine it as 'on' | 'off'. Update node version to address breaking change with typed arrays in new typescript version.
Window.location's setter now takes a string, so update MockDocument.location's setter to match.
Co-authored-by: John Jenkins <johnljenkins@Hotmail.com>
ShaneK
approved these changes
Oct 8, 2025
Contributor
ShaneK
left a comment
There was a problem hiding this comment.
This generally looks okay to me, great work!
Add ~ to typescript version to accept patch updates. Update Node types version to match necessary version update in bundler test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix new type errors. Add types array to tsconfig.json to fix a new issue with dts-bundle-generator + babel.
(timocov/dts-bundle-generator#347)
What is the current behavior?
GitHub Issue Number: N/A
What is the new behavior?
Functions passed to array maps now require an explicit type.
release-utils.ts
New typescript version detects that semver.inc returns string | null. The throw condition calls the same functions as the code below, but typescript is unable to detect that. Moving the throw to the bottom proves to typescript that getNewVersion will not return null.
tsconfig.json
Updating to typescript >5.5.4 causes a new issue with dts-bundle-generator + babel, as shown in this issue: timocov/dts-bundle-generator#347
The package author recommends adding
"types": []to the tsconfig. This will load types only for what's needed. Do Stencil users depend on these types?Documentation
Does this introduce a breaking change?
Testing
Other information