fix(runtime): stop immediate re-renders for reflected props when null !== undefined#6404
Merged
johnjenkins merged 5 commits intomainfrom Oct 1, 2025
Merged
fix(runtime): stop immediate re-renders for reflected props when null !== undefined#6404johnjenkins merged 5 commits intomainfrom
johnjenkins merged 5 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
When
@Prop({ reflect: true }) somethingis set via a property toundefined(e.g.
document.querySelector('my-thing').something = undefined) this causes the expected re-render but also causes the corresponding attribute to be removed (e.g.cmp.removeAttribute('something')) which in-turn causes the property to be set tonull, causing a double re-render which can cause errorsGitHub Issue Number: #6396
What is the new behavior?
Fixes #6396
Now, when an attribute change reflects back to it's property the assessment is
null == undefined(instead ofnull === undefined)Documentation
Does this introduce a breaking change?
Testing
Other information