fix(runtime): fixed parsing of complex attributes that contains JSON strings#6359
Merged
johnjenkins merged 3 commits intostenciljs:mainfrom Jul 28, 2025
Merged
fix(runtime): fixed parsing of complex attributes that contains JSON strings#6359johnjenkins merged 3 commits intostenciljs:mainfrom
johnjenkins merged 3 commits intostenciljs:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
The
HasAttributemember flag only includesString | Number | Boolean | Anytypes, which means that props withUnknowntypes (complex objects) are not considered to have attributes. This creates an inconsistency with thePropflag definition, which includesUnknowntypes.What is the new behavior?
The
HasAttributemember flag now includesUnknowntypes (String | Number | Boolean | Any | Unknown), making it consistent with thePropflag definition. This allows complex object props to properly support attribute-based initialization through JSON string parsing. The added test demonstrates that complex object props can now be correctly initialized via HTML attributes using JSON strings.Does this introduce a breaking change?
Testing
Added