fix(bundle): remove post order of node-resolve#6353
Merged
johnjenkins merged 2 commits intostenciljs:mainfrom Jul 28, 2025
Merged
fix(bundle): remove post order of node-resolve#6353johnjenkins merged 2 commits intostenciljs:mainfrom
johnjenkins merged 2 commits intostenciljs:mainfrom
Conversation
node-resolve resolveId hook has been moved to the end of the plugin chain, so other plugins that were meant to be called after resolve some modules incorrectly fixes: stenciljs#6335
johnjenkins
approved these changes
Jul 28, 2025
Contributor
johnjenkins
left a comment
There was a problem hiding this comment.
LGTM - thanks for contributing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
node-resolve resolveId hook has been moved to the end of the plugin chain, so other plugins that were meant to be called after resolve some modules incorrectly
GitHub Issue Number: #6335
What is the new behavior?
move the node-resolve module back to its original order
Documentation
Does this introduce a breaking change?
Testing
manually tested against the sample repo https://github.com/Fa3ris/stencil-browser-field-resolution
Other information