feat(compiler): support for CustomStateSet#6286
Merged
christian-bromann merged 3 commits intostenciljs:mainfrom Jun 25, 2025
Merged
feat(compiler): support for CustomStateSet#6286christian-bromann merged 3 commits intostenciljs:mainfrom
christian-bromann merged 3 commits intostenciljs:mainfrom
Conversation
christian-bromann
requested changes
Jun 11, 2025
Member
christian-bromann
left a comment
There was a problem hiding this comment.
Thanks for raising this PR.
Can we create a test for this? I suggest a WDIO e2e test that verifies that a component without the formAssociated flag can use element internals.
Member
|
Also could we update the docs as they should be clarify that element internals can be used without form association. |
Member
|
@pfteter mind running |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: #6285
Stencil Version
4.33
Current Behavior
@AttachInternals() internals!: ElementInternals;cannot be used without
formAssociated: truein the metadata.because of a condition in the compiler
Expected Behavior
@AttachInternals() internals!: ElementInternals;should work without
formAssociated: truein the metadata.CustomStateSet can now be used without formAssociated for components that are not formAssociated.
Improvement: Add stencil support for custom state.
System Info
Steps to Reproduce
add
@AttachInternals() internals!: ElementInternals;to a component, an console error will be shown
Code Reproduction URL
Additional Information
Will commit a fix for it, the solution is quite easy:
https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/attachInternals
Does this introduce a breaking change?
Testing
Manual testing / changing code in
node_modules